Update CircleAvatar to support Material 3
#114812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
HansMuller
reviewed
Nov 8, 2022
| Color? effectiveBackgroundColor = backgroundColor; | ||
| final Color? effectiveForegroundColor = foregroundColor | ||
| ?? (theme.useMaterial3 ? theme.colorScheme.onPrimaryContainer : null); | ||
| TextStyle textStyle = theme.primaryTextTheme.titleMedium!.copyWith(color: effectiveForegroundColor); |
There was a problem hiding this comment.
We should be using theme.textTheme here. primaryTextTheme, like primaryColorLight and primaryColorDark, are obsolete and will be deprecated when Material3 becomes the default.
There was a problem hiding this comment.
This seems to break the M2 default color. I will look into it.
theme.primaryTextTheme.titleMedium
theme. textTheme.titleMedium
| @@ -306,6 +278,61 @@ void main() { | |||
| final RenderParagraph paragraph = tester.renderObject(find.text('Z')); | |||
| expect(paragraph.text.style!.color, equals(ThemeData.fallback().primaryColorLight)); | |||
| }); | |||
|
|
|||
| group('Material 2', () { | |||
| // Tests that are only relevant for Material 2. Once ThemeData.useMaterial3 | |||
TahaTesser
force-pushed
the
m3_circle_avatar
branch
from
6646f89
to
0e17b23
Compare
This was referenced Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 9, 2022
* a84e369bd Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26e2 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59ac [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f1c [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d23 Build command dependency injection (flutter/flutter#114383) * 69a542dad Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed71 match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d53 Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Nov 9, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
percula
pushed a commit
to percula/packages
that referenced
this pull request
Nov 17, 2022
…#2791) * a84e369bd Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26e2 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59ac [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f1c [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d23 Build command dependency injection (flutter/flutter#114383) * 69a542dad Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed71 match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d53 Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114811
This PR updates
CircleAvatarto support Material 3.Since there is no theme for the
CircleAvatar, I just updated the default colors.M3 Avatar size and font are the same as the current one.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.